Add kernelCTF CVE-2023-6560_mitigation #153
Conversation
koczkatamas
force-pushed
the
master
branch
3 times, most recently
from
933028d to
c111d81
Compare
koczkatamas
force-pushed
the
master
branch
13 times, most recently
from
76d6b57 to
bf0d68f
Compare
There was a problem hiding this comment.
Hey,
This is just a quick code quality review. We're planning to review the submissions more deeply (actually understanding what the exploit does) in two weeks.
In general, the code quality looks good, I've left one comment.
We also have a draft style guide now. Please take a look and let us know if it's helpful for understanding our code quality expectations: https://google.github.io/security-research/kernelctf/style_guide.
Thanks for the submission and PR!
| sqe = (struct io_uring_sqe *)(sqes + sqes_offset); | ||
| memset(sqe, 0, sizeof(*sqe)); | ||
| sqe->opcode = IORING_OP_NOP; | ||
| sqe->user_data = 0x9c000 | 0x8000000000000067; |
There was a problem hiding this comment.
Can you comment here, what these values (0x9c000 and 0x67) mean?
More info here: https://google.github.io/security-research/kernelctf/style_guide#example-non-trivial-constant-values
There was a problem hiding this comment.
Comments added! Thanks for your feedback.
No description provided.